Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_firewall_policy deprecated dns property #9312

Closed
tesharp opened this issue Nov 13, 2020 · 2 comments · Fixed by #9332
Closed

azurerm_firewall_policy deprecated dns property #9312

tesharp opened this issue Nov 13, 2020 · 2 comments · Fixed by #9332
Assignees
Labels
service/firewall upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Milestone

Comments

@tesharp
Copy link
Contributor

tesharp commented Nov 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Affected Resource(s)

  • azurerm_firewall_policy

Terraform Configuration Files

resource "azurerm_firewall_policy" "example" {
  name                = "example"
  resource_group_name = "example"
  location            = "West Europe"

  dns {
    servers = ["1.1.1.1"]
    proxy_enabled = true
    network_rule_fqdn_enabled = true
  }
}

Debug Output

Panic Output

Expected Behaviour

Enabling dns settings on firewall policy

Actual Behaviour

Error: creating Firewall Policy "fwpolicy-westeurope" (Resource Group "rg-virtualwan"): network.FirewallPoliciesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="FirewallPolicyDeprecatedRequireProxyForNetworkRules" Message="RequireProxyForNetworkRules ( DNS Settings' Property) in Firewall Policy /subscriptions/XXXXXX/resourceGroups/rg-virtualwan/providers/Microsoft.Network/firewallPolicies/fwpolicy is deprecated for all the API Versions. Please remove the property and try again."

Steps to Reproduce

Try to create any firewall policy with dns block defined. It defaults to false for network_rule_fqdn_enabled which also produces same error message.

Important Factoids

References

  • #0000
@magodo magodo self-assigned this Nov 16, 2020
@magodo magodo added service/firewall upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Nov 16, 2020
katbyte pushed a commit that referenced this issue Nov 19, 2020
…9332)

This is due to service deprecate this property in all API versions.

Fixes: #9312
@katbyte katbyte added this to the v2.37.0 milestone Nov 19, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/firewall upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
3 participants