-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_[linux|windows]_virtual_machine
- add Data Disks support
#10466
Conversation
cdb9d98
to
57697e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
33a49a4
to
fe6e4a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look through on the whole this looks pretty good - I've left some comments inline, mostly fairly minor around naming - but main issue here is around the context, where we're firing both the Update and Read contexts off in the Update, where the Read has a smaller timeout (and these are staggered) - instead we should pass through the Update context through the entire Update method, so that we're using that timeout for this entire process. Also worth noting there's no docs for this at this time?
78f1e6d
to
0d2e3d3
Compare
c9ae5c7
to
7cbfe06
Compare
e0fda83
to
8cabb9e
Compare
Closing this for the time being due to technical limitations on implementation that are going to be resolved in future, but no set timeframe is currently available. Will re-open / start afresh as soon as possible. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR creates an Opt-in beta for allowing the use of Data Disks in-line with the Linux and Windows Virtual Machine resources. Support for local disk creation and attachment of existing disks is included.
create
disks are new disks created with the VM and can be partially managed (e.g. can be grown)attach
disks are exiting managed disks, which cannot be managed via the VM configuration.By default,
create
data disks are deleted on VM deletion, which is controlled by the features block in the provider configuration.attach
disks are always left intact by the VM.resolves #6117
Fixes #8794