-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out from properties of tags object. #1107
Merged
+141
−10
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e480825
Filter out from properties of tags object.
metacpp 030c397
Limit the filtering for $type to rule resource only and add validatio…
metacpp 46fa676
Update acceptance tests to validate the $type in attributes.
metacpp 7613d69
Add more non-exist check for metric alert rule.
metacpp bcd0e2f
Update the validation logic for test cases.
metacpp 8d50852
Move filtering logic into seprated utility function for future reuse.
metacpp 56c0805
Update the comment for filterTags function.
metacpp dac0ca1
Move validation of $type in customized tag naming into utility functi…
metacpp 044447f
Remove the validation of $type in common function.
metacpp 0edbdaf
add test case for filterTag function.
metacpp df7c9e7
Refactoring tags to match the others
tombuildsstuff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best to filter this on the individual resource where this needs to be filtered out (as people may have a legitimate use for the
$type
tag) - can we instead filter this out on the resource before calling this function? e.g.in addition - can we add some validation to ensure that the
$type
tag can't be added on that resource? We can do this using aValidateFunc
on thetags
schema item for this resource :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the code and tests.