Fix azurerm_application_insights_smart_detection_rule to support/configure all rules
#12012
Conversation
- this allows all smart detection rules to be controlled from the provider
…or internal rule name -update unit tests for new rules
ghost
added
the
komal-SkyNET
changed the title
komal-SkyNET
changed the title
|
Resolves #11999 |
komal-SkyNET
changed the title
azurerm_application_insights_smart_detection_rule needs to support/configure all rules
komal-SkyNET
changed the title
azurerm_application_insights_smart_detection_rule needs to support/configure all rules azurerm_application_insights_smart_detection_rule to support/configure all rules
| // The Smart Detection Rule name from the UI doesn't match what the API accepts. | ||
| // We'll have the user submit what the name looks like in the UI and trim it behind the scenes to match what the API accepts | ||
| name := strings.ToLower(strings.Join(strings.Split(d.Get("name").(string), " "), "")) | ||
| name := strings.Join(strings.Split(strings.ToLower(d.Get("name").(string)), " "), "") |
There was a problem hiding this comment.
this is a breaking change so we can't change this behaviour till 3.0, could we add a comment to that affect?
| "Slow page load time", | ||
| "Slow server response time", | ||
| "Long dependency duration", |
There was a problem hiding this comment.
and we'll need to keep these for people who are still using them
|
@komal-SkyNET - i'm going to close this as #12857 has been opened which addresses my feedback - thanks |
|
Thanks @katbyte! Sorry, didn't get a chance to look at this after our last conversation. Glad that it's been addressed. Do we know which release version it will be included in? |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Addresses the issue: #11999
In the smart detection resource, there is currently a validation(which has become a restriction) – that accepts only a set of rule names – that is hindering support for new rules as and when they become available. This also requires us to update our code every time a rule name is added/updated/deleted by microsoft.
To simplify this, I propose to remove this restriction so that users can reference microsoft docs and pass the internal rule name as required. This will also decouple our code from Microsoft's updates to old/new rules/names.