Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switching more resources over to using ID Parsers #15839

Merged
merged 6 commits into from
Mar 21, 2022

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, otherwise LGTM 👍🏼

Comment on lines +25 to +27
ForceNew: true,
ValidateFunc: validate.LogAnalyticsWorkspaceID,
DiffSuppressFunc: suppress.CaseDifference,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we remove these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a state migration, so it's worth leaving this in for now

Comment on lines +33 to +34
ForceNew: true,
DiffSuppressFunc: suppress.CaseDifference,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for these as well as for the properties below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a state migration, so it's worth leaving this in for now

}

newId := id.ID()
log.Printf("[DEBUG] Updating ID from %q to %q..", oldId, newId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Printf("[DEBUG] Updating ID from %q to %q..", oldId, newId)
log.Printf("[DEBUG] Updating ID from %q to %q", oldId, newId)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches the other state migrations fwiw, leaving this as-is for now

@tombuildsstuff tombuildsstuff merged commit 30562cf into main Mar 21, 2022
@tombuildsstuff tombuildsstuff deleted the f/unmanaged-ids branch March 21, 2022 16:10
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants