Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix container_registry_managed_identity_client_id #16084

Closed
wants to merge 2 commits into from
Closed

fix container_registry_managed_identity_client_id #16084

wants to merge 2 commits into from

Conversation

Dilergore
Copy link
Contributor

fix for #16083

@Dilergore
Copy link
Contributor Author

Cancelling as @jackofallops opened:
#16149

@Dilergore Dilergore closed this Mar 30, 2022
@jackofallops
Copy link
Member

Hi @Dilergore - Apologies! Your PR here wasn't linked to the issue so I assumed this was outstanding work! (I missed it in the "mentions")

If you'd like to have your PR used instead, I'm more than happy to close mine? (You'll need to update the complete test config also, however, as that's still using the id instead of the client_id) - Just let me know here.

@Dilergore
Copy link
Contributor Author

Dilergore commented Mar 30, 2022

No worries ;) Just let's have the fix as part of the next release :) Thanks @jackofallops !

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants