-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_virtual_network_gateway_connection
Add new feature to set custom_bgp_addresses
#16631
Conversation
Hi @katbyte, Regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @HappyTobi - aside from 1 comment on schema names this LGTM! once thats fixed up this should be good to merge
internal/services/network/virtual_network_gateway_connection_resource.go
Outdated
Show resolved
Hide resolved
f0e86b1
to
929c187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HappyTobi - LGTM 🍰
This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
network API upgrade had a breaking change for application gateway: #16793 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Hi all,
I just added the new Azure feature to set a "custom_bgp_address" to the virtual network gateway connection.
The configuration looks like:
Azure Documentation about that topic:
https://docs.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-howto-aws-bgp?msclkid=11de8e64c6f411eca4c7b7511dbc44d7
I also had to update the hole Networking api vom
2021-05-01
to2021-08-01
The test runs fine when I locally updated the vendor dependencies.
I don't know if I should check in the updated dependencies, if that is required please let me know.
Regards,
Tobi