Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: upgrade eventhubs sdk from 2017-04-01, 2018-01-01-preview and 2021-01-01-preview to 2021-11-01 #16644

Closed
wants to merge 8 commits into from
Closed

dependencies: upgrade eventhubs sdk from 2017-04-01, 2018-01-01-preview and 2021-01-01-preview to 2021-11-01 #16644

wants to merge 8 commits into from

Conversation

catriona-m
Copy link
Member

No description provided.

@catriona-m catriona-m requested a review from a team May 4, 2022 16:28
katbyte
katbyte requested changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we have some fialing tests:
image

@catriona-m
Copy link
Member Author

looks like we have some fialing tests: image

Thanks @katbyte - I've made some changes now that have resolved the failures, apart from some that are also failing in main currently

@tombuildsstuff
Copy link
Contributor

@catriona-m can you update this to use the new split-out SDK? https://github.com/hashicorp/go-azure-sdk/tree/main/resource-manager/eventhub/2021-11-01

tombuildsstuff added a commit that referenced this pull request Jul 22, 2022
@tombuildsstuff @catriona-m
eventhub: porting over changes from #16644
c95ff79 
Co-authored-by: catriona-m <catriona@hashicorp.com>
@tombuildsstuff tombuildsstuff mentioned this pull request Jul 22, 2022
Merged
@tombuildsstuff
Copy link
Contributor

Closing in favour of #17719

@tombuildsstuff tombuildsstuff deleted the cm/eventhubs_sdk branch July 22, 2022 08:36
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte requested changes

Assignees
No one assigned
Labels
documentation service/event-hubs EventHubs service/kusto service/monitor size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catriona-m @tombuildsstuff @katbyte