-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes_cluster
kubernetes_cluster_node_pool
- message_of_day
scale_down_mode
workload_runtime
load_balancer_profile/managed_outbound_ipv6_count
#16741
Merged
stephybun
merged 14 commits into
hashicorp:main
from
qiqingzhang:feat-aks_cluster/aks_agent_pool-supports-props
Oct 6, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b86afde
[init](aks_cluster/node_pool): supports props
qiqingzhang 864e3ff
[add]add messageOfDay in aks_cluster_node_pool
qiqingzhang 0d65663
[style] remove uselless line
qiqingzhang 9f869d9
[fix] fix message of the day to base 64(encoded) and add foece new ac…
qiqingzhang bd2ba71
[style] clean up code
qiqingzhang 2874cd2
[fix] workload_runtime can't be `WasmWasi`.
qiqingzhang f0c75a3
[modify] improve code
qiqingzhang 12f1732
Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props
ms-henglu 90e8901
Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props
ms-henglu 83afcec
fix golint
ms-henglu 89bc5fe
update
ms-henglu ff3509a
Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props
ms-henglu b5d8cfb
fix wording in docs
stephybun 07ef1e6
Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props
stephybun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
ForceNew
since we're checking for changes and updating the value below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't be updated, I'll remove the codes checking for changes and updating.