Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_data_factory - purview_id #17001

Merged
merged 2 commits into from
Jun 27, 2022
Merged

azurerm_data_factory - purview_id #17001

merged 2 commits into from
Jun 27, 2022

Conversation

shu-ying789
Copy link
Contributor

datafactory1

datafactory2

datafactory3

katbyte
katbyte requested changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have 2 test failureS:

image

@ms-henglu
Copy link
Contributor

Hi @katbyte , it seems that failed cases are not related with this enhancement, can we skip them?

@ms-henglu
Copy link
Contributor

Hi @katbyte - TestAccDataFactoryIntegrationRuntimeSelfHosted_rbac failed because there's an issue in the script used to install gateway, I've created an issue in the script repo to track it.
Azure/azure-quickstart-templates#12543

@ms-henglu
Copy link
Contributor

ms-henglu commented Jun 20, 2022 •
edited
Loading

image

image

stephybun
stephybun approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new test failures but they look to be caused by the Search service, so LGTM 👍

@stephybun stephybun merged commit a1cb0f8 into hashicorp:main Jun 27, 2022
@github-actions github-actions bot added this to the v3.12.0 milestone Jun 27, 2022
stephybun added a commit that referenced this pull request Jun 27, 2022
@stephybun
Update for #17001
73220ca
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

sergelogvinov pushed a commit to sergelogvinov/terraform-provider-azurerm that referenced this pull request Jul 11, 2022
@shu-ying789 @sergelogvinov
azurerm_data_factory - purview_id (hashicorp#17001)
26725f3 
* support purview_id

* update purview
sergelogvinov pushed a commit to sergelogvinov/terraform-provider-azurerm that referenced this pull request Jul 11, 2022
@stephybun @sergelogvinov
Update for hashicorp#17001
bdd2138
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte requested changes

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation service/data-factory size/S
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shu-ying789 @ms-henglu @katbyte @stephybun