azurerm_log_analytics_workspace - Allow field value updates while workspace is linked to a cluster
#17069
Conversation
|
@WodansSon Why just update to use the new API version then add the missing properties and enum options. |
|
@mozts2005 that would require config changes post-apply - the "right" way to fix this is by splitting the Create and Update methods here to allow users to use |
|
Why can't you just handle the config changes the way they are done for other services like when AKS creates a new version of the API? example: AKS addon_profile being removed |
| Optional: true, | ||
| ForceNew: true, | ||
| Default: string(operationalinsights.WorkspaceSkuNameEnumPerGB2018), | ||
| Computed: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ |
There was a problem hiding this comment.
we'll need to add a TODO here to add the new SKU in 4.x, remove computed, split the Create/Update and tell users to use ignore_changes here fwiw - since that's how this should be updated longer-term
There was a problem hiding this comment.
just handle it the same way it was handled for AKS
There was a problem hiding this comment.
@mozts2005 unfortunately that'd be a series of breaking changes which we can't ship until the next major version, so that's not possible in a minor release.
There was a problem hiding this comment.
I don't see why they would be braking changes you could just remap the old values to the new values.
There was a problem hiding this comment.
There was a problem hiding this comment.
also, your changes do not allow of creating a new LAW with the cluster settings.
There was a problem hiding this comment.
my need to is to make so I can use azurerm_log_analytics_workspace and azurerm_log_analytics_cluster together in an Idempotent fashion from creation and in the case of an update.
There was a problem hiding this comment.
This is by design, new LAWs can not be created with the cluster settings.
|
The only test that fails is due to the billing configuration of the subscription: |
|
|
WodansSon
changed the title
azurerm_log_analytics_workspace - Update SKU behaviorazurerm_log_analytics_workspace - Allow field value updates while workspace is linked to a cluster
|
This functionality has been released in v3.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The block on SKU change behavior was implemented incorrectly, this fixes the old implementation for the correct behavior. This is currently blocking customers.