Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Eventhub as the log analytics destination #17668

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Jul 19, 2022

If the user specify EventHubs as the destination of the log analytics, we need to use the resource id together with the metadata{eventhub_name}.

Fixing the issue:#17333

ACC TEST:
--- PASS: TestAccLogAnalyticsDataExportRule_toEventhub (512.08s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics  512.724s

(fixes #17333)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌳

@github-actions github-actions bot added size/L and removed size/XL labels Aug 2, 2022
@xiaxyi
Copy link
Contributor Author

xiaxyi commented Aug 2, 2022

Thanks @katbyte , I resolved the conflicts

@AmudaPalani
Copy link

Can you please merge this PR? Waiting for this fix.

@katbyte katbyte merged commit e97e211 into hashicorp:main Aug 2, 2022
@github-actions github-actions bot added this to the v3.17.0 milestone Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This functionality has been released in v3.17.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data export template cannot translate Event Hub destination correctly
3 participants