Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_virtual_network_swift_connection - updated documentation for associating to vNets #17734

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

bubbletroubles
Copy link
Contributor

Updated documentation for azurerm_app_service_virtual_network_swift_connection to be accurate once the following PRs are approved

#17576 - AzureRM Windows Web App
#17572 - AzureRM Windows Function App
#17494 - AzureRM Linux Function App
#17584 - AzureRM Linux Web App
#17731 - AzureRM Logic App

@bubbletroubles bubbletroubles marked this pull request as ready for review July 24, 2022 11:30
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments inline but this otherwise LGTM 👍

bubbletroubles and others added 2 commits July 26, 2022 22:46
…ml.markdown

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…ml.markdown

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@bubbletroubles
Copy link
Contributor Author

Thanks @tombuildsstuff . Suggested updates have been made and ready for re-review.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @bubbletroubles, LGTM 🥟

@stephybun stephybun merged commit b424e9c into hashicorp:main Aug 2, 2022
@github-actions github-actions bot added this to the v3.17.0 milestone Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This functionality has been released in v3.17.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
@bubbletroubles bubbletroubles deleted the swift_docs branch November 28, 2022 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants