-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_linux_web_app
- fix runtime setting for java runtime
#18155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @katbyte , updated test cases and slot settings
|
Is this also gonna be implemented for other resources (e.g. azurerm_windows_web_app)? |
azurerm_linux_web_app
: fix runtime setting for java runtimeazurerm_linux_web_app
- fix runtime setting for java runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closing as superseded by 19685 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The java runtime setting is quite flexible but the api doesn't have any restrictions to the user's input, which means, user can put whatever they want to the java runtime related properties.
We need to set a clear restrictions to these java related properties since service have a very strict reference to the property
linuxFxVersion
when setting up the app from the backend.for exmaple:
"linuxFxVersion": "JBOSSEAP|7-java8" works while
JBOSSEAP|7.0-java8
does not.fix:#16200
fix:#17144