azurerm_role_assignment - Support scope to be /providers/Microsoft.Marketplace

[ms-zhenhua]

fix #18387

[katbyte]

@ms-zhenhua - could we update the docs & add that link and an example powershell of how to grant permissions to a SP?

[ms-zhenhua]

Hi @katbyte, thank you for reviewing. I have updated the document with the related link which contains the information of how to grant permissions to different identities by Azure Portal, Azure PowerShell, Azure Cli and Rest API. Kindly help review it again. Thanks.

[manicminer]

@ms-zhenhua I've assigned the Marketplace Admin role so you should be able to test this in TC now. I've left another comment below regarding parsing the scope, if you can rework this I'll be happy to re-review. Thanks!

[ms-zhenhua]

Hi @manicminer, thank you for reviewing. The testcase needs to assign Marketplace Admin role to a new SP. But the test SP with Marketplace Admin role does not have the permission to assign Marketplace Admin role to a new SP. To make the testcase runnable on TC, could you grant the test SP with the Owner role of private marketplace?

[manicminer]

@ms-zhenhua Ah, I misunderstood, this has now been assigned. Please could you add a comment to the acctest mentioning the required owner role (with docs link)? Thanks!

[ms-zhenhua]

Hi @manicminer, thank you for your update. I have added the comments to the acctest and all related testcases have passed on TC. Kindly help review it again.

[katbyte]

@ms-zhenhua - upon some internal discussion we've come to the conclusion that the role assignment resource should probably be broken out into separate ones for each resource type for an improved UX much like we have different resource for policy assignments.

as such for this resource we could extract it out into azurerm_role_assignment_marketplace and leave the old resource to be refactored at a later time.

WDYT?

[ms-zhenhua]

Hi @katbyte, totally agree. Then I will temporarily close this PR and create a new one for the new resource azurerm_role_assignment_marketplace

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.