azurerm_monitor_diagnostic_setting - fix update issue

[teowa]

Resolves #20019

• set log_analytics_destination_type default value to AzureDiagnostics because of service API behaviour change
• fix hasEnabledLog logic and correctly set log in API payload when no log block or enabled_log block has change during resource update. Solve the at least one type of Log or Metric must be enabled error.

[jackofallops]

Hi @teowa
Thanks for this. I think it looks mostly good, but I think there's opportunity for a a couple changes that will help users of this resource. I've left some comments below to take a look at.

Thanks!

[teowa]

Thanks @jackofallops for reviewing, I have changed the code, please kindly take another look.

[katbyte]

LGTM ⛰️

[github-actions]

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[Klaas-]

nvm, there was already an issue #20140

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.