Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base layer migration #20320

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Base layer migration #20320

merged 7 commits into from
Feb 13, 2023

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Feb 5, 2023 •
edited
Loading

Note: draft branch contains changes from hashicorp/go-azure-sdk#283, hashicorp/go-azure-sdk#284, hashicorp/go-azure-sdk#285 and https://github.com/hashicorp/go-azure-helpers/pull/149/files, in addition to go-azure-sdk built from main.

Still a bunch of fixes to make, not compiling yet.

Related: hashicorp/go-azure-helpers#149 although not required for this change

Note: update when hashicorp/go-azure-sdk#291 is merged

Working Changelog

ENHANCEMENTS:

TODO

  • Documentation
  • Thorough acceptance testing

@manicminer manicminer force-pushed the base-layer-migration branch from 204e6a5 to 2052d71 Compare February 5, 2023 01:42
@manicminer
Copy link
Contributor Author

manicminer commented Feb 5, 2023 •
edited
Loading

First passing test 📎

Screenshot 2023-02-05 at 03 54 13

@manicminer manicminer mentioned this pull request Feb 6, 2023
Merged
@manicminer manicminer force-pushed the base-layer-migration branch from 2052d71 to 4397afd Compare February 6, 2023 14:44
@manicminer
Copy link
Contributor Author

manicminer commented Feb 6, 2023 •
edited
Loading

Reworked so that much fewer service package client changes are needed for existing autorest-based SDK consumers, and stock service clients should continue to work as-is. No existing services will be migrated as part of this PR, in order to minimise the scope/size.

@manicminer manicminer force-pushed the base-layer-migration branch 3 times, most recently from ea8cc1d to ddbe0ba Compare February 6, 2023 20:57
@manicminer manicminer force-pushed the base-layer-migration branch from ddbe0ba to 5e3bfa8 Compare February 6, 2023 21:22
@manicminer manicminer marked this pull request as ready for review February 6, 2023 21:29
@manicminer manicminer force-pushed the base-layer-migration branch from 5e3bfa8 to 548cec8 Compare February 7, 2023 21:21
tombuildsstuff
tombuildsstuff suggested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline but this otherwise LGTM 👍

internal/clients/auth.go Outdated Show resolved Hide resolved
internal/clients/builder.go Outdated Show resolved Hide resolved
internal/clients/builder.go Outdated Show resolved Hide resolved
internal/provider/provider.go

EnableAuthenticatingUsingClientCertificate: true,
EnableAuthenticatingUsingClientSecret: true,
EnableAuthenticatingUsingAzureCLI: enableAzureCli,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why we're introducing a feature-flag for this rather than defaulting it on?

Copy link
Contributor Author

@manicminer manicminer Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AzureAD has had this property for awhile, the intention is to provide a means of disabling CLI auth in noninteractive environments, which helps with error messages (which a lot of users report as a red herring) since instead of getting a failure mentioning Azure CLI, you'd get an error stating that no authentication methods could be configured.

website/docs/guides/service_principal_client_certificate.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/service_principal_client_certificate.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/service_principal_client_certificate.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/service_principal_client_certificate.html.markdown Show resolved Hide resolved
website/docs/guides/service_principal_client_certificate.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/service_principal_client_secret.html.markdown Show resolved Hide resolved
@manicminer manicminer force-pushed the base-layer-migration branch from 548cec8 to 5c4439d Compare February 8, 2023 20:28
@manicminer manicminer force-pushed the base-layer-migration branch from 5c4439d to cef7384 Compare February 8, 2023 20:34
tombuildsstuff
tombuildsstuff approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work @manicminer 👍

@manicminer manicminer added this to the v3.44.0 milestone Feb 13, 2023
@manicminer manicminer merged commit 4f22247 into main Feb 13, 2023
@manicminer manicminer deleted the base-layer-migration branch February 13, 2023 18:55
@github-actions
Copy link

This functionality has been released in v3.44.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@tobiaswi tobiaswi mentioned this pull request Mar 5, 2023
Closed
1 task
@manicminer manicminer mentioned this pull request Mar 17, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
authentication azure/china azure/germany azure/government dependencies documentation provider sdk/requires-upgrade This is dependent upon upgrading an SDK service/api-management service/app-configuration service/app-service service/logic service/resources service/storage service/synapse size/XL
Projects
None yet
Milestone
v3.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @tombuildsstuff