Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_manager_scope_connection, azurerm_network_manager_subscription_connection, azurerm_network_manager_management_group_connection - add resource delete check #20840

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Mar 8, 2023

Add stateChangeConf.WaitForStateContext(ctx) to make sure the connection is deleted. This may fix the failed test case in test subscription.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗑️

@katbyte katbyte merged commit b3735fa into hashicorp:main Mar 23, 2023
@github-actions github-actions bot added this to the v3.49.0 milestone Mar 23, 2023
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants