Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updating logz to use github.com/hashicorp/go-azure-sdk #21321

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

@tombuildsstuff tombuildsstuff requested a review from a team April 6, 2023 16:03
@tombuildsstuff tombuildsstuff added this to the v3.51.0 milestone Apr 6, 2023
@tombuildsstuff tombuildsstuff marked this pull request as draft April 6, 2023 16:04
@tombuildsstuff tombuildsstuff marked this pull request as ready for review April 6, 2023 16:11
@katbyte katbyte modified the milestones: v3.51.0, v3.52.0 Apr 7, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

------ Stdout: -------
=== RUN   TestAccLogzSubAccountTagRule_update
=== PAUSE TestAccLogzSubAccountTagRule_update
=== CONT  TestAccLogzSubAccountTagRule_update
    testcase.go:110: Step 1/6 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement
        
        Terraform will perform the following actions:
        
          # azurerm_logz_sub_account.test must be replaced
        -/+ resource "azurerm_logz_sub_account" "test" {
              ~ id              = "/subscriptions/*******/resourceGroups/acctest-logz-230413232714224994/providers/Microsoft.Logz/monitors/acctest-lm-230413232714224994/accounts/acctest-lsa-230413232714224994" -> (known after apply)
                name            = "acctest-lsa-230413232714224994"
                # (2 unchanged attributes hidden)
        
              + user { # forces replacement
                  + email        = "a9c283cf-9045-40f0-aecf-d8738e5ed103@example.com" # forces replacement
                  + first_name   = "first" # forces replacement
                  + last_name    = "last" # forces replacement
                  + phone_number = "123456" # forces replacement
                }
            }
        
          # azurerm_logz_sub_account_tag_rule.test must be replaced
        -/+ resource "azurerm_logz_sub_account_tag_rule" "test" {
              ~ id                     = "/subscriptions/*******/resourceGroups/acctest-logz-230413232714224994/providers/Microsoft.Logz/monitors/acctest-lm-230413232714224994/accounts/acctest-lsa-230413232714224994/tagRules/default" -> (known after apply)
              ~ logz_sub_account_id    = "/subscriptions/*******/resourceGroups/acctest-logz-230413232714224994/providers/Microsoft.Logz/monitors/acctest-lm-230413232714224994/accounts/acctest-lsa-230413232714224994" -> (known after apply) # forces replacement
                # (3 unchanged attributes hidden)
            }
        
        Plan: 2 to add, 0 to change, 2 to destroy.
--- FAIL: TestAccLogzSubAccountTagRule_update (491.60s)
FAIL

@katbyte katbyte modified the milestones: v3.52.0, v3.53.0 Apr 14, 2023
@tombuildsstuff tombuildsstuff force-pushed the refactor/logz-to-go-azure-sdk branch from d7aa488 to 94ef5d1 Compare April 17, 2023 05:39
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are passing now LGTM 🌈

@stephybun stephybun merged commit b7a2f42 into main Apr 17, 2023
@stephybun stephybun deleted the refactor/logz-to-go-azure-sdk branch April 17, 2023 14:02
stephybun added a commit that referenced this pull request Apr 17, 2023
@github-actions
Copy link

This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants