azurerm_machine_learning_compute_instance azurerm_machine_learning_compute_cluster - support for the node_public_ip_enabled property
#21706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_compute_cluster` - `node_public_ip_enabled`
ms-henglu
force-pushed
the
ticket-17291318-mls-enable-node-public-ip
branch
from
957045f to
6ff01fb
Compare
|
Hi, I believe this is related to my PR #21377. I've added the changes to run the tests. Your version looks cleaner. I think you're missing the new setting in the acceptance tests, I believe it requires private endpoints too. |
|
Hi @Lucasjuv , Thanks for the information! I didn't notice there's already a PR supporting this feature, I'll close mine since yours is already being reviewed. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the
prevent_deletion_if_contains_resources = falseflag to destroy theMicrosoft.alertsmanagement/smartDetectorAlertRules/Failure Anomaliesrule which is auto-applied by the policy.