azurerm_cognitive_deployment - Add support for VersionUpgradeOption

[lonegunmanb]

Add support for VersionUpgradeOption so the users can set the model's version they like. This pr should fix #22501 .

[mbfrahry]

Hey @lonegunmanb, this change is a good start but we should write a test for this as well. It also looks like the API defaults this value to OnceNewDefaultVersionAvailable so we'll want to account for that as well

[lonegunmanb]

Roger that, will do

[lonegunmanb]

Hi @mbfrahry I have to change the model used in e2e test since the original model is deprecated now. Would you please give this pr a review? Thanks!

[manicminer]

@lonegunmanb Thanks for updating the tests. It looks like the model got reverted to the older one when main got merged in, was this intentional?

[lonegunmanb]

@lonegunmanb Thanks for updating the tests. It looks like the model got reverted to the older one when main got merged in, was this intentional?

Whoops... My bad, I must mess it up when I tried to merge the code, thanks for pointing out.

[lonegunmanb]

Hi @manicminer @mbfrahry I've rebased the pr to the latest main branch, and I've upgraded the model version in the e2e test so all acc tests could pass on my side. Would you please give this r another review? Thanks!

[manicminer]

Thanks @lonegunmanb. I'm getting a test failure with a 400 response.

[lonegunmanb]

I'll see what I can do to solve this testing issue.

[lonegunmanb]

Hi @manicminer I've tried to switch the region but still got no luck. I've checked the team city's history, the same errors occurred before on the main branch. The tests got the green light on our testing subscription:

=== RUN   TestAccCognitiveDeploymentSequential
--- PASS: TestAccCognitiveDeploymentSequential (784.22s)
=== RUN   TestAccCognitiveDeploymentSequential/deployment
    --- PASS: TestAccCognitiveDeploymentSequential/deployment (784.22s)
=== RUN   TestAccCognitiveDeploymentSequential/deployment/basic
        --- PASS: TestAccCognitiveDeploymentSequential/deployment/basic (262.07s)
=== RUN   TestAccCognitiveDeploymentSequential/deployment/requiresImport
        --- PASS: TestAccCognitiveDeploymentSequential/deployment/requiresImport (269.03s)
=== RUN   TestAccCognitiveDeploymentSequential/deployment/complete
        --- PASS: TestAccCognitiveDeploymentSequential/deployment/complete (253.12s)
PASS

Could we approve this pr for now? Or maybe we need to open a support ticket on your side I guess? Anyway, thanks for reading, waiting for your further instructions.

[manicminer]

@lonegunmanb We need to be able to test this. It looks like we'll have to submit an application for access to the service

[jayendranarumugam]

Hello @manicminer , Is there any timeline for when this can be verified and merged? We are currently blocked with this. As there is no way for us to upgrade to a new version. Is there any way we can help ? Thanks!

[dkmiller]

@manicminer is there any way we could help with testing?

[MChorfa]

Hello @mbfrahry,
Is there a way to get this through? I can help with the testing as well
Thank you :)

[katbyte]

LGTM ⚙️

[jayendranarumugam]

It also looks like the API defaults this value to OnceNewDefaultVersionAvailable so we'll want to account for that as well

Hey @mbfrahry May I know from where this default is defined?

From the doc

null is equivalent to AutoUpgradeWhenExpired. If the Version update policy option is not present in the properties for a model that supports model upgrades this indicates the value is currently null. Once you explicitly modify this value the property will be visible in the studio properties page as well as via the REST API.

AutoUpgradeWhenExpired will be like OnceCurrentVersionExpired. So the default should be OnceCurrentVersionExpired is it ? Due to this change in the PR. My existing tfstate deployment are causing forces replacement

09    # azurerm_cognitive_deployment.generic_deployment["gpt-35-turbo"] must be replaced
16:51:09  -/+ resource "azurerm_cognitive_deployment" "generic_deployment" {
16:51:09        ~ id                     = "/subscriptions/xx/resourceGroups/ai-services-rg-01/providers/Microsoft.CognitiveServices/-cog-01/dex/gpt-35-txurbo-deployment-01" -> (known after apply)
16:51:09          name                   = "gpt-35-turbo-deployment-01"
16:51:09        ~ version_upgrade_option = "OnceCurrentVersionExpired" -> "OnceNewDefaultVersionAvailable" # forces replacement
16:51:09          # (2 unchanged attributes hidden)
16:51:09  
16:51:09        ~ scale {
16:51:09              # (2 unchanged attributes hidden)
16:51:09          }
16:51:09  
16:51:09          # (1 unchanged block hidden)
16:51:09      }
16:51:09  

I can raise a PR for a quick fix. Do let me know thoughts @katbyte

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.