Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apimanagement: pulling the location field from the API rather than the local config during deletion #22752

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 31, 2023

d.Get isn't guaranteed to return a value during the Delete methods - therefore we need to look this up from the Remote API instead.

Fixes https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/5712688553/job/15476668791?pr=22748

… config

The config isn't necessarily available during the Delete, so we cannot rely on this
@tombuildsstuff tombuildsstuff added this to the v3.68.0 milestone Jul 31, 2023
@tombuildsstuff tombuildsstuff requested a review from a team July 31, 2023 10:35
@tombuildsstuff tombuildsstuff marked this pull request as ready for review July 31, 2023 15:40
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Tests look fine 👍

@tombuildsstuff tombuildsstuff merged commit a59ea0d into main Aug 1, 2023
@tombuildsstuff tombuildsstuff deleted the b/api-management-pull-from-api branch August 1, 2023 07:04
tombuildsstuff added a commit that referenced this pull request Aug 1, 2023
tombuildsstuff added a commit that referenced this pull request Aug 1, 2023
tombuildsstuff added a commit that referenced this pull request Aug 1, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants