Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_api_management_backend: fix dereference pointer may cause panic #23219

Merged
merged 2 commits into from
Sep 11, 2023
Merged

azurerm_api_management_backend: fix dereference pointer may cause panic #23219

merged 2 commits into from
Sep 11, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Sep 8, 2023

fixes #23192

@rcskosir rcskosir mentioned this pull request Sep 8, 2023
Closed
1 task
tombuildsstuff
tombuildsstuff suggested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but this otherwise LGTM 👍

internal/services/apimanagement/api_management_backend_resource.go Outdated Show resolved Hide resolved
tombuildsstuff
tombuildsstuff approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.73.0 milestone Sep 11, 2023
@tombuildsstuff tombuildsstuff merged commit 999c27f into hashicorp:main Sep 11, 2023
tombuildsstuff added a commit that referenced this pull request Sep 11, 2023
@tombuildsstuff
updating to include #23219
a419873
@wuxu92 wuxu92 deleted the fix/apimpanic branch September 12, 2023 00:42
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
service/api-management size/XS
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

Terraform v1.5.6, terraform-provider-azurerm_v3.71.0_x5 is crashing while running plan or apply
2 participants
@wuxu92 @tombuildsstuff