[TestCase] azurerm_maps_account - update sku_name value in the test case #23563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
suggested changes
Oct 16, 2023
| @@ -40,6 +40,8 @@ The following arguments are supported: | |||
|
|
|||
| * `sku_name` - (Required) The SKU of the Azure Maps Account. Possible values are `S0`, `S1` and `G2`. Changing this forces a new resource to be created. | |||
|
|
|||
| ~> **Note:** `S0` and `S1` are deprecated by Service API. Suggest to use `G2`. Please see more at this [document](https://learn.microsoft.com/azure/azure-maps/how-to-manage-pricing-tier). | |||
There was a problem hiding this comment.
Suggested change
| ~> **Note:** `S0` and `S1` are deprecated by Service API. Suggest to use `G2`. Please see more at this [document](https://learn.microsoft.com/azure/azure-maps/how-to-manage-pricing-tier). | |
| ~> **Note:** Gen1 SKUs (`S0` and `S1`) are deprecated and can no longer be used for new deployments, which should instead use a Gen2 SKU (`G2`) - more information can be found [in the Azure documentation](https://learn.microsoft.com/azure/azure-maps/how-to-manage-pricing-tier). |
There was a problem hiding this comment.
Thanks. Updated
|
@tombuildsstuff , thanks for the comment. I updated PR. Please take another look. Thanks. |
catriona-m
approved these changes
Oct 16, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, test cases about Maps Account in Teamcity are failed. After investigated, I found that skus
S0andS1and kindGen1are deprecated. So I updated test cases.Note: I didn't remove the deprecated skus from the validation since we shouldn't block the user who is using the existing resource with S0 and S1.