Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/update-go-azure-sdk: fixing a couple of nits #23588

Merged
merged 2 commits into from
Oct 17, 2023
Merged

tools/update-go-azure-sdk: fixing a couple of nits #23588

merged 2 commits into from
Oct 17, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR fixes a couple of issues spotted when running the update-go-azure-sdk tool, which:

  1. Handles import path aliases (e.g. example "github.com/hashicorp/...")
  2. Ensures that when parsing the imports we only pull the current API versions from imports for the specified service
  3. Outputs the absolute path to both hashicorp/go-azure-sdk and hashicorp/terraform-provider-azurerm for debugging purposes

catriona-m
catriona-m approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff added this to the v3.77.0 milestone Oct 17, 2023
@tombuildsstuff tombuildsstuff merged commit 7574d90 into main Oct 17, 2023
20 checks passed
@tombuildsstuff tombuildsstuff deleted the b/fixing-nits-in-update-go-azure-sdk-tooling branch October 17, 2023 11:18
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
size/S tooling
Projects
None yet
Milestone
v3.77.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @catriona-m