azurerm_ip_group: parse and normalize firewall/policy id in read

[wuxu92]

Should fix #24018.

These IDs are computed properties but will be parsed in Update. We should always parse and format these values.

[tombuildsstuff]

hi @wuxu92

Thanks for this PR - taking a look through it appears that whilst this'll fix this for users with -refresh=true, the underlying issue still exists - as such can we ensure we fix the issue across the Resource, rather than just in the Read function?

Thanks!

[tombuildsstuff]

this'll default to nil rather than []string fwiw, so we want to make this:

Suggested change

	var firewallPolicyIDs []string
	firewallPolicyIDs := make([]string, 0)

[wuxu92]

Updated! I'm just wondering if the SDK treats nil and empty slices differently. Should we always provide a non-nil value when calling d.Set()?

[tombuildsstuff]

this'll default to nil rather than []string fwiw, so we want to make this:

Suggested change

	var firewallIDs []string
	firewallIDs := make([]string, 0)

[tombuildsstuff]

This issue still exists however - particularly in the Delete but also if the validation is wrong in the Create/Update/if refresh is disabled:

1. Update the Create function so that the Parse function raises an error when parsing fails
2. Update the Update function so that the Parse function raises an error when parsing fails
3. Update the Delete function so that the Parse function raises an error when parsing fails - but also to load the values from the Azure API, since we shouldn't be using d.Get in the Delete function.

As such, can we update this?

[wuxu92]

Thanks and Updated!

[tombuildsstuff]

LGTM 👍 - thanks for pushing those changes @wuxu92

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.