-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to handle Consumption in workload profile #24302
Conversation
Can anyone look into this ASAP? |
@DenisBalan Is it possible to also add the GPU profiles (preview) to this? Validation rule prevents selection of |
Is this not the same as this PR? #24277 |
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
Please merge this PR. Thanks |
Any update? |
I don`t think this is the same, because you can choose the default workload profile, which is the 'consumption', but it is not the consumptionOnly environment type. This is quite confusing. |
The Azure Verified Module (https://aka.ms/AVM) here supports the consumption only environment: https://registry.terraform.io/modules/Azure/avm-res-app-managedenvironment/azurerm/latest Example: module "managedenvironment" {
source = "Azure/avm-res-app-managedenvironment/azurerm"
version = "0.1.0"
name = "cae-my-example"
resource_group_name = azurerm_resource_group.this.name
infrastructure_subnet_id = azurerm_subnet.this.id
workload_consumption_profile_enabled = true
zone_redundancy_enabled = true
log_analytics_workspace_customer_id = azurerm_log_analytics_workspace.this.workspace_id
log_analytics_workspace_primary_shared_key = azurerm_log_analytics_workspace.this.primary_shared_key
} |
hey @DenisBalan Thanks for this PR - taking a look through here it appears this PR has been superseded/included as a part of #25285 and as such I hope you don't mind but I'm going to close this PR in favour of that one, which'll ship in this weeks release. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
As part of #23478 workload profiles were introduced.
There is an important distinction between
Consumption
as a type of workload profile andConsumption
completly apart from workload profile.This PR is to add
Consumption
as workload profile type.ref: https://learn.microsoft.com/en-us/azure/container-apps/workload-profiles-overview#profile-types
related also: #21747