azurerm_container_registry_task_schedule_run_now: fix state tracking

[walkline]

With the current implementation, there is a chance that we may track the state of the wrong run during creation process.

Here is my use case. With this request, I received the following response:

{
   "value":[
      {
         "type":"Microsoft.ContainerRegistry/registries/runs",
         "properties":{
            "runId":"cb1m",
            "status":"Queued",
            "lastUpdatedTime":"2024-01-22T19:22:00+00:00",
            "runType":"QuickRun",
            "createTime":"2024-01-22T19:22:00.6783774+00:00",
            "platform":{
               
            },
            "agentConfiguration":{
               
            },
            "provisioningState":"Succeeded",
            "isArchiveEnabled":false
         },
         "id":"***",
         "name":"cb1m",
         "systemData":{
            "lastModifiedBy":"****",
            "lastModifiedByType":"User",
            "lastModifiedAt":"2024-01-22T19:22:00.5717814+00:00"
         }
      },
      {
         "type":"Microsoft.ContainerRegistry/registries/runs",
         "properties":{
            "runId":"cb1k",
            "status":"Succeeded",
            "lastUpdatedTime":"2024-01-22T18:58:51+00:00",
            "runType":"QuickRun",
            "createTime":"2024-01-22T18:58:27.9292755+00:00",
            "startTime":"2024-01-22T18:58:28.3975826+00:00",
            "finishTime":"2024-01-22T18:58:51.6189431+00:00",
            "task":"mx-app-image-builder",
            "platform":{
               "os":"Linux"
            },
            "agentConfiguration":{
               "cpu":2
            },
            "provisioningState":"Succeeded",
            "isArchiveEnabled":false
         },
         "id":"***",
         "name":"cb1k",
         "systemData":{
            "lastModifiedBy":"***",
            "lastModifiedByType":"User",
            "lastModifiedAt":"2024-01-22T18:58:27.8583581+00:00"
         }
      }
   ]
}

From this response, it's obvious that we should choose the cb1m run, which is in a Queued status. However, we chose the cb1k run to track because this condition fails, as cb1m doesn't have a task field.

As a result, Terraform picks the wrong run, and the object is instantly created since cb1k has a Success status.

With the proposed changes, I couldn't reproduce the issue.

This may also possibly resolve this issue: #23334.

[stephybun]

Thanks for this @walkline LGTM ⚡

[github-actions]

This functionality has been released in v3.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[walkline]

Hey @stephybun. Now resource creation is broken, because of the changes to the azure sdk in vendor folder.
It always throws this error:

if scheduleResp.Model == nil {
  return fmt.Errorf("ScheduleRun model was nil for taskID %s", taskId)
}

Can you help me to solve this?

[stephybun]

@walkline apologies, I hadn't realised this change was dependent on the SDK change we made (and then reverted).

It should be possible to do a manual unmarshal of the response payload, below is a snippet that can hopefully get you started.

scheduleResp, err := registryClient.ScheduleRun(ctx, registryId, req)
if err != nil {
  return fmt.Errorf("scheduling the task: %+v", err)
}
if scheduleResp.HttpResponse != nil {
  if err = scheduleResp.HttpResponse.Unmarshal(&scheduleResp.Model); err != nil {
    return
  }
}
if scheduleResp.Model == nil {
  return fmt.Errorf("ScheduleRun model was nil for taskID %s", taskId)
}

Please shout if you require more assistance!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.