-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable terraform-plugin-mux
for Framework base support in 4.0
#26057
Conversation
16511fe
to
b81a96a
Compare
b81a96a
to
4131da1
Compare
4131da1
to
3ae0c6d
Compare
err error | ||
) | ||
|
||
if metadataHost := data.MetaDataHost.ValueString(); metadataHost != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add a comment around how we handle the metadatahost and env selection process here?
19da8c3
to
d4e2a40
Compare
d4e2a40
to
d4e8628
Compare
Discussed internally, review now out of date
2d34221
to
ecff80a
Compare
refactor providerfunction package to function to match other major prvider implementations Requires changes to go-azure-helpers to support this commit
add enums for resouceprovider sets add helper function GetResourceProvidersSet
…ut muxed provider behind fourpointoh feature flag
33298b4
to
215427e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jackofallops, a few minor suggestions but otherwise looks great 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
provider-mux
to pave the way forterraform-plugin-framework
adoption postv4.0
Community Note
Description
This PR presents the first stage of support for
terraform-provider-framework
by introducing themux
server.Use of the
mux
also allows for the addition of Provider Functions, a prototype function is included.NOTE: This is WIP PR to facilitate testing across a wide selection of services and resources in CI and is no part is guaranteed to be taken forward and/or merged.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
This is a (please select all that apply):