network: fix acc tests failures of versino beta 4

[wuxu92]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Over 260 tests failed when the 4.0 beta flag was enabled in the main branch, compared to only 25-30 failures in 3.0 mode.

there are less than 40 failures in this branch:

66 failures the prev commit:

I fixed some issues and reran part of the 66 failed cases; 27 of them passed. Now, fewer than 40 cases remain unresolved need to be checked manually.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Many thanks for fixing these up @wuxu92. I just have one question about why we're changing the setting of a property from true to false, otherwise this looks good.

[stephybun]

Many of these are getting set to false when they were true before, could you explain why?

[wuxu92]

This is because the original property enforce_private_link_service_network_policies has unusual expansion logic, which is the opposite of the new property private_link_service_network_policies_enabled and in version 4.0. The same applies to enforce_private_link_endpoint_network_policies and private_endpoint_network_policies_enabled. Therefore, the tool includes special logic to change the value from true to false.

terraform-provider-azurerm/internal/services/network/subnet_resource.go

Lines 824 to 834 in f990134

	// TODO 4.0: Remove expandEnforceSubnetPrivateLinkNetworkPolicy function
	func expandEnforceSubnetNetworkPolicy(enabled bool) string {
	// This is strange logic, but to get the schema to make sense for the end user
	// I exposed it with the same name that the Azure CLI does to be consistent
	// between the tool sets, which means true == Disabled.
	if enabled {
	return string(subnets.VirtualNetworkPrivateEndpointNetworkPoliciesDisabled)
	}
	return string(subnets.VirtualNetworkPrivateEndpointNetworkPoliciesEnabled)
	}

[stephybun]

Thanks @wuxu92 LGTM 💯

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.