Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the DDoS Protection Plan issue in Virtual Network #2676

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Fix the DDoS Protection Plan issue in Virtual Network #2676

merged 5 commits into from
Jan 16, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Jan 15, 2019 •
edited
Loading

This PR includes the quick fix to mitigate the non-empty plan w/ empty ddos_protection_plan setting in vnet. Thanks @hbuckle to point it out in #2654 .

@ghost ghost added the size/XS label Jan 15, 2019
@metacpp metacpp requested a review from katbyte January 15, 2019 19:37
@metacpp metacpp added this to the 2.0.0 milestone Jan 15, 2019
@metacpp metacpp requested review from WodansSon and JunyiYi January 15, 2019 19:52
@ghost ghost added the documentation label Jan 15, 2019
@metacpp metacpp changed the title Fix the ddos plan issue in vnet Fix the DDos Protection Plan issue in Virtual Network Jan 15, 2019
WodansSon
WodansSon approved these changes Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacpp Thanks for the PR, it mostly LGTM. Left a very minor question about the docs, other than that I'd say ship it. 🥇

website/docs/r/virtual_network.html.markdown Outdated Show resolved Hide resolved
website/docs/r/virtual_network.html.markdown Outdated Show resolved Hide resolved
@metacpp metacpp changed the title Fix the DDos Protection Plan issue in Virtual Network Fix the DDoS Protection Plan issue in Virtual Network Jan 16, 2019
WodansSon and others added 2 commits January 15, 2019 16:30
@WodansSon @metacpp
Update website/docs/r/virtual_network.html.markdown
a47def6 
Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
@metacpp
Fix: change DDos to DDoS.
47907bf
@ghost ghost added size/L and removed size/XS labels Jan 16, 2019
katbyte
katbyte approved these changes Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @metacpp

@katbyte katbyte merged commit b9d99d2 into master Jan 16, 2019
tombuildsstuff
tombuildsstuff reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a couple of minor things whilst passing through 🙂

website/docs/r/virtual_network.html.markdown Show resolved Hide resolved
azurerm/provider.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 21, 2019
@tombuildsstuff tombuildsstuff deleted the ddos_fix branch February 5, 2019 22:02
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@WodansSon WodansSon WodansSon approved these changes

@katbyte katbyte katbyte approved these changes

@JunyiYi JunyiYi Awaiting requested review from JunyiYi

Assignees
No one assigned
Labels
documentation service/virtual-networks size/L
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@metacpp @tombuildsstuff @katbyte @WodansSon