Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentinel - fix tests for 4.0 #26952

Closed
wants to merge 1 commit into from
Closed

sentinel - fix tests for 4.0 #26952

wants to merge 1 commit into from

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Aug 6, 2024

data "azurerm_sentinel_alert_rule_template" "test" {
  display_name               = "Advanced Multistage Attack Detection"
  log_analytics_workspace_id = azurerm_log_analytics_solution.test.workspace_resource_id
  depends_on = [azurerm_sentinel_log_analytics_workspace_onboarding.test]
}

is enabled by Default so we'll disable it when pulling it into the provider to get tests passing again

We're also removing Conditions: expandAutomationRuleConditions(d.Get("condition").([]interface{})), as we do the 4.0 check down below and this is causing a panic

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant