Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check storage account name in a given subscription during create and update calls for azurerm_machine_learning_datastore_datalake_gen2 resource #27256

Closed
wants to merge 2 commits into from

Conversation

harshavmb
Copy link
Contributor

…update calls

modified:   internal/services/machinelearning/machine_learning_datastore_datalake_gen2_resource.go

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • [ x ] I have followed the guidelines in our Contributing Documentation.
  • [ x ] I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • [ x ] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • [ x ] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • [ x ] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

  • [ x ] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation. (difficult to test as it requires alias via providers I am not sure which subscription to use for testing)
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • [ x ] Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27254

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…update calls

	modified:   internal/services/machinelearning/machine_learning_datastore_datalake_gen2_resource.go
@catriona-m
Copy link
Member

Hi @harshavmb thanks for submitting this - it looks like this may be addressed by #28123 which has been merged now. So we may be able to close this one, WDYT?

@harshavmb
Copy link
Contributor Author

Hi @harshavmb thanks for submitting this - it looks like this may be addressed by #28123 which has been merged now. So we may be able to close this one, WDYT?

sure, please close if #28123 supports this.

@catriona-m
Copy link
Member

Thank you @harshavmb - I will close this now then.

@catriona-m catriona-m closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants