-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New resource] azurerm_machine_learning_workspace_network_outbound_rule_fqdn
#27384
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d2d1252
add mlw outboundrule client
xuzhang3 638e753
add support for machine learning workspace network outbound rule FQDN
xuzhang3 e1230af
format doc
xuzhang3 ea6fb02
update vendor
xuzhang3 4be4e4d
update document
xuzhang3 93161fc
rename document
xuzhang3 84abcc8
Merge branch 'main' into f/mlw_outbound_rule_fqdn
xuzhang3 4279428
fix acctests
xuzhang3 b510523
rename destination to destination_fqdn
xuzhang3 b6a01b8
Merge remote-tracking branch 'upstream/main' into f/mlw_outbound_rule…
xuzhang3 2d6d9a9
update vendor files
xuzhang3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
231 changes: 231 additions & 0 deletions
231
...ervices/machinelearning/machine_learning_workspace_network_outbound_rule_fqdn_resource.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,231 @@ | ||
// Copyright (c) HashiCorp, Inc. | ||
// SPDX-License-Identifier: MPL-2.0 | ||
|
||
package machinelearning | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"time" | ||
|
||
"github.com/hashicorp/go-azure-helpers/lang/pointer" | ||
"github.com/hashicorp/go-azure-helpers/lang/response" | ||
"github.com/hashicorp/go-azure-sdk/resource-manager/machinelearningservices/2024-04-01/managednetwork" | ||
"github.com/hashicorp/go-azure-sdk/resource-manager/machinelearningservices/2024-04-01/workspaces" | ||
"github.com/hashicorp/terraform-provider-azurerm/helpers/tf" | ||
"github.com/hashicorp/terraform-provider-azurerm/internal/sdk" | ||
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk" | ||
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/validation" | ||
) | ||
|
||
var _ sdk.ResourceWithUpdate = WorkspaceNetworkOutboundRuleFqdn{} | ||
|
||
type machineLearningWorkspaceOutboundRuleFqdnModel struct { | ||
Name string `tfschema:"name"` | ||
WorkspaceId string `tfschema:"workspace_id"` | ||
Destination string `tfschema:"destination_fqdn"` | ||
} | ||
|
||
type WorkspaceNetworkOutboundRuleFqdn struct{} | ||
|
||
var _ sdk.Resource = WorkspaceNetworkOutboundRuleFqdn{} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) ResourceType() string { | ||
return "azurerm_machine_learning_workspace_network_outbound_rule_fqdn" | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) ModelObject() interface{} { | ||
return &machineLearningWorkspaceOutboundRuleFqdnModel{} | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) IDValidationFunc() pluginsdk.SchemaValidateFunc { | ||
return managednetwork.ValidateOutboundRuleID | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) Arguments() map[string]*pluginsdk.Schema { | ||
arguments := map[string]*pluginsdk.Schema{ | ||
"name": { | ||
Type: pluginsdk.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
ValidateFunc: validation.StringIsNotEmpty, | ||
}, | ||
|
||
"workspace_id": { | ||
Type: pluginsdk.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
ValidateFunc: managednetwork.ValidateWorkspaceID, | ||
}, | ||
|
||
"destination_fqdn": { | ||
Type: pluginsdk.TypeString, | ||
Required: true, | ||
ValidateFunc: validation.StringIsNotEmpty, | ||
}, | ||
} | ||
return arguments | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) Attributes() map[string]*pluginsdk.Schema { | ||
return map[string]*pluginsdk.Schema{} | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) Create() sdk.ResourceFunc { | ||
return sdk.ResourceFunc{ | ||
Timeout: 30 * time.Minute, | ||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||
var model machineLearningWorkspaceOutboundRuleFqdnModel | ||
if err := metadata.Decode(&model); err != nil { | ||
return fmt.Errorf("decoding: %+v", err) | ||
} | ||
|
||
client := metadata.Client.MachineLearning.ManagedNetwork | ||
subscriptionId := metadata.Client.Account.SubscriptionId | ||
|
||
workspaceId, err := managednetwork.ParseWorkspaceID(model.WorkspaceId) | ||
if err != nil { | ||
return err | ||
} | ||
id := managednetwork.NewOutboundRuleID(subscriptionId, workspaceId.ResourceGroupName, workspaceId.WorkspaceName, model.Name) | ||
existing, err := client.SettingsRuleGet(ctx, id) | ||
if err != nil { | ||
if !response.WasNotFound(existing.HttpResponse) { | ||
return fmt.Errorf("checking for presence of existing %s: %+v", id, err) | ||
} | ||
} | ||
if !response.WasNotFound(existing.HttpResponse) { | ||
return tf.ImportAsExistsError("azurerm_machine_learning_workspace_network_outbound_rule_fqdn", id.ID()) | ||
} | ||
|
||
outboundRule := managednetwork.OutboundRuleBasicResource{ | ||
Name: pointer.To(model.Name), | ||
Type: pointer.To(string(managednetwork.RuleTypeFQDN)), | ||
Properties: managednetwork.FqdnOutboundRule{ | ||
Category: pointer.To(managednetwork.RuleCategoryUserDefined), | ||
Destination: &model.Destination, | ||
}, | ||
} | ||
|
||
if err = client.SettingsRuleCreateOrUpdateThenPoll(ctx, id, outboundRule); err != nil { | ||
return fmt.Errorf("creating %s: %+v", id, err) | ||
} | ||
|
||
metadata.SetID(id) | ||
return nil | ||
}, | ||
} | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) Update() sdk.ResourceFunc { | ||
return sdk.ResourceFunc{ | ||
Timeout: 30 * time.Minute, | ||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||
var model machineLearningWorkspaceOutboundRuleFqdnModel | ||
if err := metadata.Decode(&model); err != nil { | ||
return fmt.Errorf("decoding: %+v", err) | ||
} | ||
|
||
client := metadata.Client.MachineLearning.ManagedNetwork | ||
id, err := managednetwork.ParseOutboundRuleID(metadata.ResourceData.Id()) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
existing, err := client.SettingsRuleGet(ctx, *id) | ||
if err != nil { | ||
return fmt.Errorf("retrieving %s: %+v", id, err) | ||
} | ||
|
||
if existing.Model == nil { | ||
return fmt.Errorf("retrieving %s: `model` was nil", id) | ||
} | ||
|
||
if existing.Model.Properties == nil { | ||
return fmt.Errorf("retrieving %s: `properties` was nil", id) | ||
} | ||
|
||
payload := existing.Model | ||
|
||
if metadata.ResourceData.HasChange("destination_fqdn") { | ||
payload.Properties = managednetwork.FqdnOutboundRule{ | ||
Destination: &model.Destination, | ||
} | ||
} | ||
|
||
if err = client.SettingsRuleCreateOrUpdateThenPoll(ctx, *id, *payload); err != nil { | ||
return fmt.Errorf("updating %s: %+v", id, err) | ||
} | ||
return nil | ||
}, | ||
} | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) Read() sdk.ResourceFunc { | ||
return sdk.ResourceFunc{ | ||
Timeout: 5 * time.Minute, | ||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||
client := metadata.Client.MachineLearning.ManagedNetwork | ||
|
||
id, err := managednetwork.ParseOutboundRuleID(metadata.ResourceData.Id()) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
resp, err := client.SettingsRuleGet(ctx, *id) | ||
if err != nil { | ||
if response.WasNotFound(resp.HttpResponse) { | ||
return metadata.MarkAsGone(id) | ||
} | ||
|
||
return fmt.Errorf("retrieving %s: %+v", *id, err) | ||
} | ||
|
||
model := resp.Model | ||
if model == nil { | ||
return fmt.Errorf("retrieving %s: model was nil", id) | ||
} | ||
|
||
state := machineLearningWorkspaceOutboundRuleFqdnModel{ | ||
Name: id.OutboundRuleName, | ||
} | ||
|
||
if props := model.Properties; props != nil { | ||
if prop, ok := props.(managednetwork.FqdnOutboundRule); ok { | ||
if prop.Destination != nil { | ||
state.Destination = *prop.Destination | ||
} | ||
} | ||
} | ||
|
||
state.WorkspaceId = workspaces.NewWorkspaceID(metadata.Client.Account.SubscriptionId, id.ResourceGroupName, id.WorkspaceName).ID() | ||
|
||
return metadata.Encode(&state) | ||
}, | ||
} | ||
} | ||
|
||
func (r WorkspaceNetworkOutboundRuleFqdn) Delete() sdk.ResourceFunc { | ||
return sdk.ResourceFunc{ | ||
Timeout: 30 * time.Minute, | ||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||
client := metadata.Client.MachineLearning.ManagedNetwork | ||
|
||
id, err := managednetwork.ParseOutboundRuleID(metadata.ResourceData.Id()) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
future, err := client.SettingsRuleDelete(ctx, *id) | ||
if err != nil { | ||
return fmt.Errorf("deleting Machine Learning Workspace FQDN Network Outbound Rule %q (Resource Group %q, Workspace %q): %+v", id.OutboundRuleName, id.ResourceGroupName, id.WorkspaceName, err) | ||
} | ||
|
||
if err = future.Poller.PollUntilDone(ctx); err != nil { | ||
return fmt.Errorf("waiting for deletion of Machine Learning Workspace FQDN Network Outbound Rule %q (Resource Group %q, Workspace %q): %+v", id.OutboundRuleName, id.ResourceGroupName, id.WorkspaceName, err) | ||
} | ||
|
||
return nil | ||
}, | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be validating this is a FQDN?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no restriction on FQDN in the portal, as long as it is a string, checking that the string should not be empty is enough