New Resource: azurerm_container_registry_credential_set

[jan-mrm]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adding a new resource in order to manage Credential Sets for Azure Container Registries.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

none

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

make acctests SERVICE='containers' TESTARGS='-run=TestAccContainerRegistryCredentialSet_' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccContainerRegistryCredentialSet_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccContainerRegistryCredentialSet_basic
=== PAUSE TestAccContainerRegistryCredentialSet_basic
=== RUN   TestAccContainerRegistryCredentialSet_requiresImport
=== PAUSE TestAccContainerRegistryCredentialSet_requiresImport
=== RUN   TestAccContainerRegistryCredentialSet_update
=== PAUSE TestAccContainerRegistryCredentialSet_update
=== CONT  TestAccContainerRegistryCredentialSet_basic
=== CONT  TestAccContainerRegistryCredentialSet_update
=== CONT  TestAccContainerRegistryCredentialSet_requiresImport
--- PASS: TestAccContainerRegistryCredentialSet_basic (120.32s)
--- PASS: TestAccContainerRegistryCredentialSet_requiresImport (122.08s)
--- PASS: TestAccContainerRegistryCredentialSet_update (156.95s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    159.627s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_container_registry_credential_set - New resource for managing Credential Sets of Container Registries [New Resource: azurerm_container_registry_credential_set #27528]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Closes #26539

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[rs-sh]

@stephybun with the caching rule enforcing docker.io credentials this needs to be bumped up in priority for review, please. :)

[stephybun]

We call a normalising function on the identity type returned here in the flatten functions of the identity package because the API is often inconsistent with the casing

https://github.com/hashicorp/go-azure-helpers/blob/624ef4f92d9f94a4a467b2bf5fb79974ef6c3255/resourcemanager/identity/constants.go#L20-L38

We can do this and it should take care of the casing issue for us

Suggested change

	Type: input.Type,
	Type: identity.Type(input.Type),

[jan-mrm]

I tested that and it did not resolve the issue 🫤

[stephybun]

@jan-mrm I've opened a PR on Pandora which will patch the SDK to match the behaviour we see in the API (instead of what's been defined in the Rest API spec). Once that's made it through to hashicorp/go-azure-sdk we can bump the version in the provider, rebase this PR on top of main and get rid of the custom expand/flatten which will resolve the casing issue.