-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_api_management_api fix the bug in example usage #27758
Conversation
As I described in the issue, the root cause is invalid url because following worked well. So, we can just change the content_value but I still suggest to remove this block from example usage because the same fate can happen to any new url and confuse the users. This block is just optional and many dont use it at all so it's not worth confusing the rest of users.
|
Added extra explanation
Added following to the doc so readers will be informed about this nuanced error:
|
@stephybun can you please check this PR? |
Swapped the content of `content_value` with a working link.
@stephybun thanks for suggestion. Replaced it with a working link. It should be ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @azarboon LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
The example usage has a bug. I've explained it in detail in the issue #27757. My PR makes the example usage to work seamlessly. I've tested it locally and it worked. The removed section is optional so it can be removed from the example usage. Though, that removed property, probably needs further investigations which can be done separately.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #27757,
Fixes #24379,
Fixes #23130
Note
If this PR changes meaningfully during the course of review please update the title and description as required.