azurerm_nginx_deployment: Deprecate logging_storage_account block
#27894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as a draft pending an internal discussion with our team. |
stephybun
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks @puneetsarna! Aside from the one comment left in-line this look good! Once that comment is resolved this should be good to go.
| @@ -264,6 +264,27 @@ func (m DeploymentResource) Arguments() map[string]*pluginsdk.Schema { | |||
| "tags": commonschema.Tags(), | |||
| } | |||
|
|
|||
| if !features.FivePointOhBeta() { | |||
| resource["logging_storage_account"] = &pluginsdk.Schema{ | |||
| Deprecated: "The `logging_storage_account` block has been deprecated and will be removed in v5.0 of the AzureRM Provider. To enable logs, use `azurerm_monitor_diagnostic_setting` resource instead.", | |||
There was a problem hiding this comment.
Suggested change
| Deprecated: "The `logging_storage_account` block has been deprecated and will be removed in v5.0 of the AzureRM Provider. To enable logs, use `azurerm_monitor_diagnostic_setting` resource instead.", | |
| Deprecated: "The `logging_storage_account` block has been deprecated and will be removed in v5.0 of the AzureRM Provider. To enable logs, use the `azurerm_monitor_diagnostic_setting` resource instead.", |
puneetsarna
force-pushed
the
ps-dev-log-retirement
branch
from
514e05c to
726a5b0
Compare
NGINXaaS for Azure is deprecating the use of `logging_storage_account` block in favor of using Azure native logging configured via Azure Diagnostic Settings.
puneetsarna
force-pushed
the
ps-dev-log-retirement
branch
from
726a5b0 to
72d3c54
Compare
|
@stephybun Thanks for reviewing this. I have pushed fixes to the PR around properly deprecating the block. Passing tests with 5.0 set: ==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccNginxDeploymentDataSource_basic -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccNginxDeploymentDataSource_basic
=== PAUSE TestAccNginxDeploymentDataSource_basic
=== CONT TestAccNginxDeploymentDataSource_basic
--- PASS: TestAccNginxDeploymentDataSource_basic (409.10s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx 414.838s
(reverse-i-search)`make': make e2e.nginx args="-k test_insecure_upstreams"
terraform-provider-azurerm $ make acctests SERVICE='nginx' TESTARGS='-run=TestAccNginxDeployment_basic'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccNginxDeployment_basic -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccNginxDeployment_basic
=== PAUSE TestAccNginxDeployment_basic
=== CONT TestAccNginxDeployment_basic
--- PASS: TestAccNginxDeployment_basic (395.95s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx 398.634s |
…ource to 5.0 upgrade guide
stephybun
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Thanks @puneetsarna! I totally missed that the upgrade guide wasn't updated. Hope you don't mind I pushed a commit to update the upgrade guide to your branch.
LGTM 💯
|
@stephybun Thanks for taking care of the upgrade guide 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINXaaS for Azure is deprecating the use of
logging_storage_accountblock in favor of usingAzure native logging configured via Azure
Diagnostic Settings.
Community Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.