azurerm_search_service:Update basic SKU partition count from 1 to 3

[Gnana-Bharathi-K]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

Thanks for this @Gnana-Bharathi-K - this looks good to me, but could we include a basic sku with partition count set to 3 in the tests so we can confirm this works as expected? Thanks!

[Gnana-Bharathi-K]

Hi @catriona-m Thanks for reviewing I have updated the basic SKU partition count in tests to 3 from 4 kindly please review the tests. Added the conditions to check the count and error message as well to prompt if partition count greater than 3

[catriona-m]

Hi @Gnana-Bharathi-K I've left one comment inline for you to consider. It would be good if we could also add a test with a basic sku and partition count of 3 to ensure it is working correctly. Thanks!

[Gnana-Bharathi-K]

Hi @catriona-m The Test Results for your reference

Please let me know if further details required

[catriona-m]

Hi @catriona-m The Test Results for your reference

Please let me know if further details required

Thanks for updating the existing test @Gnana-Bharathi-K.

Could you also add a new test using the partitionCount config using a basic sku and a partition count of 3 so that we can confirm that it is possible to create an azurerm_search_service with a basic sku and a partition count of 3.

Thank you!

[Gnana-Bharathi-K]

Hi @catriona-m executed the test function with partition count 3 and SKU as basic, the search service successfully deployed in the azure portal.

Resource Group Name "acctestRG-search-241126180102558706"
search service name "acctestsearchservice241126180102558706"

I have added separate combined test function "TestAccSearchService_partitionCountvalidBySkuBasic" to test and let me know if we need separate test function only for deployment or combined test function.

Result when I passed basic sku with partition count 4

[Gnana-Bharathi-K]

Hi @catriona-m , please let me know is there something I need to perform !

[catriona-m]

Thanks for updating this @Gnana-Bharathi-K - it looks like there's a linting issue, could you run make fmt on this to fix it? Thanks!

[Gnana-Bharathi-K]

Hi @catriona-m updated the format of the file search_service_resource_test.go

[Gnana-Bharathi-K]

@catriona-m Updated the lint format with running gofmt against the file search_service_resource_test.go there was an extra line space which was resolved.

[Gnana-Bharathi-K]

I think all the test cases been passed successfully, is there something we still need to review @catriona-m ?

[Gnana-Bharathi-K]

@catriona-m please let me know if the there is any changes need to be done by my end thanks !

[catriona-m]

Thanks for updating this @Gnana-Bharathi-K - LGTM!

[Gnana-Bharathi-K]

Hi @catriona-m thanks for updates and I guess everything went well ! Let me know if something needs to addressed thanks for the collaboration!