-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] azurerm_express_route_connection
- Remove private_link_fast_path_enabled
#28161
base: main
Are you sure you want to change the base?
[Deprecation] azurerm_express_route_connection
- Remove private_link_fast_path_enabled
#28161
Conversation
azurerm_express_route_connection
- Remove private_link_fast_path_enabled
azurerm_express_route_connection
- Remove private_link_fast_path_enabled
resource.Schema["private_link_fast_path_enabled"] = &pluginsdk.Schema{ | ||
Type: pluginsdk.TypeBool, | ||
Optional: true, | ||
Deprecated: "'private_link_fast_path_enabled' has been deprecated as it is no longer supported by the resource and will be removed in v5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated: "'private_link_fast_path_enabled' has been deprecated as it is no longer supported by the resource and will be removed in v5", | |
Deprecated: "'private_link_fast_path_enabled' has been deprecated as it is no longer supported by the resource and will be removed in v5.0 of the AzureRM Provider", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecate message updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuzhang3 just left one minor comment inline for you to consider. Thanks!
### `azurerm_express_route_connection` | ||
|
||
* The deprecated `private_link_fast_path_enabled` property has been removed as it is no longer supported by the resource. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be moved further up to be in alphabetical order with the rest of the resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
private_link_fast_path_enabled
is supported by the Virtual Network Gateway(Express Route) but the Express Route Gateway(Visual Wans) does not. These two resource have the same name but are slightly different. This has been confirmed by the service. This PR will removeprivate_link_fast_path_enabled
to avoid unexpected errors.Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.