Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] azurerm_express_route_connection - Remove private_link_fast_path_enabled #28161

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Dec 3, 2024

private_link_fast_path_enabled is supported by the Virtual Network Gateway(Express Route) but the Express Route Gateway(Visual Wans) does not. These two resource have the same name but are slightly different. This has been confirmed by the service. This PR will remove private_link_fast_path_enabled to avoid unexpected errors.

Resource property Support
Virtual Network Gateway(type ExpressRoute) --> connection EnablePrivateLinkFastPath Yes
Virtual Wans -> Virtual Hub -> Express Route Gateway --> connection EnablePrivateLinkFastPath No

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions bot added the bug label Dec 3, 2024
@xuzhang3 xuzhang3 changed the title [Bug Fix] azurerm_express_route_connection - Remove private_link_fast_path_enabled [Deprecation] azurerm_express_route_connection - Remove private_link_fast_path_enabled Dec 6, 2024
@xuzhang3 xuzhang3 marked this pull request as ready for review December 6, 2024 10:03
@xuzhang3 xuzhang3 requested a review from a team as a code owner December 6, 2024 10:03
resource.Schema["private_link_fast_path_enabled"] = &pluginsdk.Schema{
Type: pluginsdk.TypeBool,
Optional: true,
Deprecated: "'private_link_fast_path_enabled' has been deprecated as it is no longer supported by the resource and will be removed in v5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deprecated: "'private_link_fast_path_enabled' has been deprecated as it is no longer supported by the resource and will be removed in v5",
Deprecated: "'private_link_fast_path_enabled' has been deprecated as it is no longer supported by the resource and will be removed in v5.0 of the AzureRM Provider",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecate message updated.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xuzhang3 just left one minor comment inline for you to consider. Thanks!

Comment on lines 123 to 126
### `azurerm_express_route_connection`

* The deprecated `private_link_fast_path_enabled` property has been removed as it is no longer supported by the resource.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be moved further up to be in alphabetical order with the rest of the resources?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants