-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_app β support for termination_grace_period_seconds #28307
base: main
Are you sure you want to change the base?
azurerm_container_app β support for termination_grace_period_seconds #28307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CheeseMite thanks for submitting this. This is looking good but it looks like there is a linting error - could you run make terrafmt
on the test file which should hopefully fix this? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the linting @CheeseMite - I just left one small query but will take another look soon. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CheeseMite - I just noticed this needs a different docs file, but otherwise this is looking good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this docs file is for the the datasource, could we move this change to website/docs/r/container_app.html.markdown?
Community Note
Description
Add support for
termination_grace_period_seconds
property of theazurerm_container_app
resourcePR Checklist
For example: β
resource_name_here
- description of change e.g. adding propertynew_property_name_here
βChanges to existing Resource / Data Source
Change Log
azurerm_container_app
- support for thetermination_grace_period_seconds
propertyThis is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.