azurerm_mssql_database - support 100MB and 500MB for max_size_gb

[sinbai]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support 100MB and 500MB for max_size_gb

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccMsSqlDatabase_maxSizeGB (912.62s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_mssql_database - support 100MB and 500MB for max_size_gb [azurerm_mssql_database max_size_gb doesn't allow 100MB or 500MB values #28289]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28289

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

Thanks for submitting this @sinbai - I just left one comment around the testing for this, but once that is addressed I can take another look. Thanks!

[catriona-m]

we shouldn't be adding max_size_gb to data.ImportStep on any of the tests - could you have another look at this change to get these passing without the need for this?

[sinbai]

Hi @catriona-m thanks for your time and feedback. Adding max_size_gb to data.ImportStep is because the following reason. Could you please give any other suggestions for this situation?

[catriona-m]

these tests are currently passing in main so we need to investigate why this change would be causing a different value to be returned