-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_(windows|linux)_virtual_machine
- adding os_disk
ID attribute
#28352
Conversation
os_disk
ID attribute
os_disk
ID attributeazurerm_(windows|linux)_virtual_machine
- adding os_disk
ID attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…bute (hashicorp#28352) * Add vm OS disk ID attribute * Update docs
* Update CHANGELOG.md for #28233 * Update for #28215 * Update CHANGELOG.md for #28279 * Update CHANGELOG.md #28269 * Update CHANGELOG.md #27876 * Update CHANGELOG.md #28069 * Update CHANGELOG.md for #28312 * Update CHANGELOG.md for #28278 * Update CHANGELOG.md #28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md #27874 * Update CHANGELOG.md * Update CHANGELOG for #28352 * Update CHANGELOG.md for #28390 * Update CHANGELOG.md for #28398 * Update CHANGELOG.md for #28425 * Update CHANGELOG.md #28427 * Update CHANGELOG.md #28280 * Update CHANGELOG.md for #28319 * Update CHANGELOG.md #24801 * Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442 * Update for #28379 * Update CHANGELOG.md for #28281 * Update for #28380 * Update for #27375 * Update for #25695 * Update CHANGELOG.md #27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: kt <kt@katbyte.me>
…bute (hashicorp#28352) * Add vm OS disk ID attribute * Update docs
* Update CHANGELOG.md for hashicorp#28233 * Update for hashicorp#28215 * Update CHANGELOG.md for hashicorp#28279 * Update CHANGELOG.md hashicorp#28269 * Update CHANGELOG.md hashicorp#27876 * Update CHANGELOG.md hashicorp#28069 * Update CHANGELOG.md for hashicorp#28312 * Update CHANGELOG.md for hashicorp#28278 * Update CHANGELOG.md hashicorp#28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md hashicorp#27874 * Update CHANGELOG.md * Update CHANGELOG for hashicorp#28352 * Update CHANGELOG.md for hashicorp#28390 * Update CHANGELOG.md for hashicorp#28398 * Update CHANGELOG.md for hashicorp#28425 * Update CHANGELOG.md hashicorp#28427 * Update CHANGELOG.md hashicorp#28280 * Update CHANGELOG.md for hashicorp#28319 * Update CHANGELOG.md hashicorp#24801 * Update for hashicorp#28360 hashicorp#28216 hashicorp#27830 hashicorp#28404 hashicorp#27401 hashicorp#27122 hashicorp#27931 hashicorp#28442 * Update for hashicorp#28379 * Update CHANGELOG.md for hashicorp#28281 * Update for hashicorp#28380 * Update for hashicorp#27375 * Update for hashicorp#25695 * Update CHANGELOG.md hashicorp#27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: kt <kt@katbyte.me>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Added
os_disk.id
attributePR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_windows_virtual_machine
- added os_disk ID attribute [azurerm_(windows|linux)_virtual_machine
- addingos_disk
ID attribute #28352]azurerm_linux_virtual_machine
- added os_disk ID attribute [azurerm_(windows|linux)_virtual_machine
- addingos_disk
ID attribute #28352]This is a (please select all that apply):
Related Issue(s)
Fixes #13533
Note
If this PR changes meaningfully during the course of review please update the title and description as required.