Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add features {} to the provider block #28370

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Dec 23, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

A follow up of #28052, where there are acctests have the provider "azurerm" {} block, but empty.

This PR uses the same way as #28052, finding out test configs that have no features defined, via

$ grep -rL "features" | sort
TestAccRoleManagementPolicyDataSource_managementGroup/0/terraform_plugin_test.tf
TestAccRoleManagementPolicyDataSource_resource/0/terraform_plugin_test.tf
TestAccRoleManagementPolicyDataSource_resourceGroup/0/terraform_plugin_test.tf
TestAccRoleManagementPolicyDataSource_subscription/0/terraform_plugin_test.tf
TestAccRoleManagementPolicy_managementGroup/0/terraform_plugin_test.tf
TestAccRoleManagementPolicy_resource/0/terraform_plugin_test.tf
TestAccRoleManagementPolicy_resource/2/terraform_plugin_test.tf
TestAccRoleManagementPolicy_resourceGroup/0/terraform_plugin_test.tf
TestAccRoleManagementPolicy_resourceGroup/2/terraform_plugin_test.tf
TestAccRoleManagementPolicy_resourceGroup_activationRulesUpdate/0/terraform_plugin_test.tf
TestAccRoleManagementPolicy_resourceGroup_activationRulesUpdate/2/terraform_plugin_test.tf
TestAccRoleManagementPolicy_subscription/0/terraform_plugin_test.tf
TestAccRoleManagementPolicy_subscription/2/terraform_plugin_test.tf
TestAccStorageBlob_appendEmpty/0/terraform_plugin_test.tf
TestAccStorageBlob_appendEmptyMetaData/0/terraform_plugin_test.tf
TestAccStorageBlob_archive/0/terraform_plugin_test.tf
TestAccStorageBlob_blockEmpty/0/terraform_plugin_test.tf
TestAccStorageBlob_blockEmptyAzureADAuth/0/terraform_plugin_test.tf
TestAccStorageBlob_disappears/0/terraform_plugin_test.tf

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

@katbyte katbyte merged commit 2129b95 into hashicorp:main Dec 26, 2024
31 of 33 checks passed
@github-actions github-actions bot added this to the v4.15.0 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants