Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_compute_skus #28382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tiwood
Copy link
Contributor

@tiwood tiwood commented Dec 25, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This adds a new data source to query available compute SKUs for a subscription.
This is helpful to check if the desired SKU is available before the apply phase, or to check if the SKU has the desired capabilities.

Example:

data "azurerm_compute_skus" "available" {
  name     = "Standard_D2s_v3"
  location = "westus"
}

output "available_skus" {
  value = {
    for sku in data.azurerm_compute_skus.available.skus : sku.name => sku
  }
}
data.azurerm_compute_skus.available: Reading...
data.azurerm_compute_skus.available: Still reading... [10s elapsed]
data.azurerm_compute_skus.available: Read complete after 15s [id=2e93e7f8-6a87-4db2-90cc-3b8bf65e8521]

Changes to Outputs:
  + available_skus = {
      + Standard_D2s_v3 = {
          + capabilities          = {}
          + location_restrictions = []
          + name                  = "Standard_D2s_v3"
          + resource_type         = "virtualMachines"
          + size                  = "D2s_v3"
          + tier                  = "Standard"
          + zone_restrictions     = [
              + "3",
              + "1",
            ]
          + zones                 = [
              + "2",
              + "1",
              + "3",
            ]
        }
    }

You can apply this plan to save these new output values to the Terraform state, without changing any real
infrastructure.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@tiwood
Copy link
Contributor Author

tiwood commented Dec 25, 2024

Tests pass:

image

@tiwood tiwood force-pushed the feat/r/compute_skus branch from 56f95b9 to b829cf2 Compare December 25, 2024 22:52
@tiwood tiwood marked this pull request as ready for review December 25, 2024 22:52
@tiwood tiwood requested a review from a team as a code owner December 25, 2024 22:52
@tiwood tiwood changed the title feat(ds/compute_skus): New data source data.azurerm_compute_skus New data source azurerm_compute_skus Dec 30, 2024
@tiwood tiwood changed the title New data source azurerm_compute_skus New data source: azurerm_compute_skus Dec 30, 2024
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @tiwood! We no longer accept untyped data sources or resources in the provider. Before we proceed with a detailed review could I please ask you to rewrite this as a typed data source? The contributor guidelines on adding a new data source can help you with this.

@tiwood
Copy link
Contributor Author

tiwood commented Jan 13, 2025

@stephybun, thanks for the heads-up. I've made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants