Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting - new/updated linter violations #28505

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

jackofallops
Copy link
Member

also addresses several potential bugs:

  • azurerm_mssql_database - fix bug where verifying TDE might fail to return an error on failure
  • azurerm_mssql_database - fix several potential bugs where retry functions could return false negatives for actual errors
  • azurerm_private_endpoint - fix a bug where reading Private DNS could error and exit the Read of the resource early without raising an error

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@jackofallops jackofallops merged commit b45bfb9 into main Jan 14, 2025
30 checks passed
@jackofallops jackofallops deleted the linting/violations-on-main branch January 14, 2025 16:35
@github-actions github-actions bot added this to the v4.16.0 milestone Jan 14, 2025
jackofallops added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants