Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for mistyped id #320

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Add test for mistyped id #320

merged 1 commit into from
Sep 11, 2017

Conversation

mbfrahry
Copy link
Member

This PR fixes #267. If a user passes in a mistyped ID, Terraform will error.

make testacc TEST=./azurerm TESTARGS="-run=TestAccAzureRMPublicIpStatic_importIdError"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMPublicIpStatic_importIdError -timeout 120m
=== RUN   TestAccAzureRMPublicIpStatic_importIdError
--- PASS: TestAccAzureRMPublicIpStatic_importIdError (67.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	67.554s

@mbfrahry
Copy link
Member Author

This PR fixes #267

tombuildsstuff
tombuildsstuff approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - presuming the existing PublicIP tests pass :)

@mbfrahry
Copy link
Member Author

Tests are passing!

@mbfrahry mbfrahry merged commit d48b02a into master Sep 11, 2017
tombuildsstuff added a commit that referenced this pull request Sep 12, 2017
@tombuildsstuff
Updating to include #320
6e3c569
@mbfrahry mbfrahry deleted the b-import-public-ip branch September 12, 2017 15:54
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash for import azurerm_public_ip
2 participants
@mbfrahry @tombuildsstuff