Add validation to sql server name #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
suggested changes
Sep 12, 2017
azurerm/resource_arm_sql_server.go
Outdated
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validateAzureRmSQLDBAccountName, |
There was a problem hiding this comment.
given this is validating the server name, would this make more sense asvalidateSQLServerName?
| @@ -74,6 +75,23 @@ func TestAccAzureRMSqlServer_basic(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccAzureRMSqlServer_upperCaseName(t *testing.T) { | |||
| ri := acctest.RandInt() | |||
| config := testAccAzureRMSqlServer_upperCaseName(ri, testLocation()) | |||
There was a problem hiding this comment.
whilst this works, could we swap this out for some unit tests with both valid and invalid examples?, ala this?
|
tombuildsstuff
approved these changes
Sep 12, 2017
azurerm/validators_test.go
Outdated
|
|
||
| if len(errors) != tc.ErrCount { | ||
| t.Fatalf("Expected the AzureRM SQL Server Name to trigger a validation error for '%s'", tc.Value) | ||
| } |
There was a problem hiding this comment.
I think we can remove this secondary validation function?
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to sql server name. From #314