P doc updates #342
P doc updates #342
Conversation
There was a problem hiding this comment.
Hey @mbfrahry
Thanks for this - I've left a couple of minor 🤔 but this otherwise LGTM :)
| @@ -113,14 +113,14 @@ $ az account list-locations | |||
|
|
|||
| ### Creating a Service Principal in the Azure Portal | |||
|
|
|||
| There's a couple of phases to create a Service Principal via [the Azure Portal](https://portal.azure.com): | |||
| We need to do two more steps to create a Service Principal via [the Azure Portal](https://portal.azure.com): | |||
There was a problem hiding this comment.
I think this'd read better as There's two tasks needed to create a Service Principal via [the Azure Portal](https://portal.azure.com): or Two tasks are needed to create a Service Principal via [the Azure Portal](https://portal.azure.com): - what do you think?
There was a problem hiding this comment.
That sounds good to me!
| @@ -9,13 +9,13 @@ description: |- | |||
|
|
|||
| # Authenticating to Azure Resource Manager using the Azure CLI | |||
|
|
|||
| Terraform supports authenticating to Azure through a couple of different means - via a Service Principal and using the Azure CLI. | |||
| Terraform supports authenticating to Azure through two different means; a Service Principal or the Azure CLI. | |||
There was a problem hiding this comment.
🤔 reading this again, I'm wondering if this might read better as ...through the Azure CLI or a Service Principal (Shared Account) - what do you think?
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Hey Tom. I just wanted to reword a few things. Take or leave any of these changes!