New Resource: Azure Front Door #3933

WodansSon · 2019-07-26T01:57:15Z

Adding support for Azure Frontdoor Service

[fixes: #3186]

katbyte

Thanks for the PR @jeffreyCline,

Overall this looks really good, i've left a bunch of mostly minor comments inline that once addressed this should be good to go 👍

website/docs/r/front_door.html.markdown

azurerm/resource_arm_front_door.go

katbyte · 2019-08-21T17:46:27Z

azurerm/resource_arm_front_door.go

+			ID:   id,
+			Name: utils.String(name),
+			FrontendEndpointProperties: &frontdoor.FrontendEndpointProperties{
+				// ResourceState:


What is the point of these comments 🤔

I put them there to show which attributes are in the structure that I have omitted from terraform, it made it easier to keep straight in my head when I was comparing the SDK structs to what I implemented within Terraform.

I suggest either removing them or adding a comment to that effect then

I have removed them.

azurerm/resource_arm_front_door.go

Co-Authored-By: kt <kt@katbyte.me>

website/docs/r/front_door.html.markdown

Co-Authored-By: kt <kt@katbyte.me>

…/terraform-provider-azurerm into nr_frontdoor

katbyte

Thanks for the changes @jeffreyCline,

Going through this once more, the main thing that stands out is the passing multiple parameters down the stack when we could generate the front door ID once and pass it down instead. I think this would clean up the code a bunch and make it easier to follow.

katbyte · 2019-08-30T22:13:30Z

azurerm/internal/services/frontdoor/helper/helper.go

@@ -0,0 +1,85 @@
+package helper


Could we just move this one up into the front door package?

I tried moving it but go got confused with the path.

katbyte · 2019-08-30T22:13:35Z

azurerm/internal/services/frontdoor/validate/validate.go

@@ -0,0 +1,172 @@
+package validate


Could we just move this one up into the front door package?

I tried moving it but go got confused with the path.

katbyte · 2019-08-30T22:13:59Z

azurerm/internal/services/frontdoor/validate/validate.go

+)
+
+//Frontdoor name must begin with a letter or number, end with a letter or number and may contain only letters, numbers or hyphens.
+func FrontDoorName(i interface{}, k string) (_ []string, errors []error) {


This would then become

Suggested change

func FrontDoorName(i interface{}, k string) (_ []string, errors []error) {

func ValidateFrontDoorName(i interface{}, k string) (_ []string, errors []error) {

Yep. Fixed.

katbyte · 2019-08-30T22:14:07Z

azurerm/internal/services/frontdoor/validate/validate.go

+	return nil, errors
+}
+
+func BackendPoolRoutingRuleName(i interface{}, k string) (_ []string, errors []error) {


Suggested change

func BackendPoolRoutingRuleName(i interface{}, k string) (_ []string, errors []error) {

func ValidateBackendPoolRoutingRuleName(i interface{}, k string) (_ []string, errors []error) {

Yep, Fixed.

katbyte · 2019-08-30T22:19:12Z

azurerm/resource_arm_front_door.go

+		}
+		d.Set("friendly_name", properties.FriendlyName)
+
+		if frontDoorFrontendEndpoints, err := flattenArmFrontDoorFrontendEndpoint(properties.FrontendEndpoints, resourceGroup, *resp.Name, meta); frontDoorFrontendEndpoints != nil {


I think we should be nil checking resp.name here?

Sure, fixed.

katbyte · 2019-08-30T22:26:21Z

azurerm/resource_arm_front_door.go

+	}
+
+	output := make([]map[string]interface{}, 0)
+


Suggested change

katbyte · 2019-08-30T22:27:03Z

azurerm/resource_arm_front_door.go

+			result["host_header"] = *backendHostHeader
+		}
+
+		if v.EnabledState == frontdoor.Enabled {


We should replace this with:

Suggested change

if v.EnabledState == frontdoor.Enabled {

result["enabled"] = v.EnabledState == frontdoor.Enabled

katbyte · 2019-08-30T22:27:29Z

azurerm/resource_arm_front_door.go

+					}
+				}
+
+				//result["web_application_firewall_policy_link"] = flattenArmFrontDoorFrontendEndpointUpdateParameters_webApplicationFirewallPolicyLink(properties.WebApplicationFirewallPolicyLink)


We should remove this comment ?

Suggested change

//result["web_application_firewall_policy_link"] = flattenArmFrontDoorFrontendEndpointUpdateParameters_webApplicationFirewallPolicyLink(properties.WebApplicationFirewallPolicyLink)

katbyte · 2019-08-30T22:39:22Z

azurerm/resource_arm_front_door.go

+}
+
+func expandArmFrontDoorSubResource(subscriptionId string, resourceGroup string, frontDoorName string, resourceType string, resourceName string) *frontdoor.SubResource {
+	result := frontdoor.SubResource{


Instead of having this function could we just assign frontdoor.SubResource inline so its clear what is going on?

Sure, fixed.

azurerm/resource_arm_front_door.go

katbyte

Thanks for the revisions @jeffreyCline, LGTM 👍

WodansSon · 2019-09-07T02:27:18Z

ghost · 2019-09-18T12:13:56Z

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

ghost · 2019-10-07T14:50:31Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

WodansSon added 17 commits May 13, 2019 18:19

WIP: Initial checkin

73b0c47

Updates to Frontdoor

7b2be6d

Merge from Master

6dcab9c

PIP

1cb59ce

PIP

200f2a8

Finalized Schema

8291122

WIP Current state

7d66366

WIP adding validation

0f412eb

WIP Finished validation code

4440bab

WIP Expand RoutingRules working

04adc2f

WIP All expand func implemented

cf9096f

WIP: Functional CreateUpdate done

00a51cd

Cast values and start on flatten functions

68b84d0

WIP: Last fix routing rules

c40fcc9

WIP: Fully working Frontdoor

35c4502

WIP: Wasnt exactly done... fixed destroy

7481722

gofmt code

88e5f6a

WodansSon added new-resource service/frontdoor labels Jul 26, 2019

WodansSon requested review from tombuildsstuff and katbyte July 26, 2019 01:57

ghost added size/XXL dependencies documentation labels Jul 26, 2019

WodansSon modified the milestones: v1.32.1, v1.33.0 Jul 26, 2019

Pull Master

0a42aa7

WodansSon changed the title ~~[WIP]New Resource: Frontdoor~~ [WIP]New Resource: Azure Front Door Jul 26, 2019

WIP: Added first test

156b97b

update CheckDestroy func

b721403

katbyte modified the milestones: v1.33.0, v1.34.0 Aug 21, 2019

katbyte requested changes Aug 21, 2019

View reviewed changes

katbyte reviewed Aug 21, 2019

View reviewed changes

azurerm/resource_arm_front_door.go Show resolved Hide resolved

WodansSon and others added 8 commits August 21, 2019 16:17

Update website/docs/r/front_door.html.markdown

822ef9d

Co-Authored-By: kt <kt@katbyte.me>

Update azurerm/resource_arm_front_door.go

d54b7fc

Co-Authored-By: kt <kt@katbyte.me>

Update azurerm/resource_arm_front_door.go

262b1f9

Co-Authored-By: kt <kt@katbyte.me>

Update test and docs

ba08bca

Fixed conflict

e251d71

Added test case

f25eed4

Update test per PR

d21382e

Address PR issues

28383a9

katbyte reviewed Aug 22, 2019

View reviewed changes

website/docs/r/front_door.html.markdown Show resolved Hide resolved

website/docs/r/front_door.html.markdown Outdated Show resolved Hide resolved

WodansSon and others added 4 commits August 22, 2019 01:17

Update website/docs/r/front_door.html.markdown

c592646

Co-Authored-By: kt <kt@katbyte.me>

Added link to internal bug tracking casing issue

5f49486

Merge branch 'nr_frontdoor' of https://github.com/terraform-providers…

f39e2d6

…/terraform-provider-azurerm into nr_frontdoor

gofmt

3ed1561

katbyte requested changes Aug 30, 2019

View reviewed changes

WodansSon added 3 commits September 4, 2019 19:47

Fixes per PR comments

4425f84

Moving package(s) and refactor

b99238f

gofmt

fe5bf89

katbyte approved these changes Sep 7, 2019

View reviewed changes

WodansSon merged commit 7c1971d into master Sep 7, 2019

WodansSon deleted the nr_frontdoor branch September 7, 2019 02:28

WodansSon added a commit that referenced this pull request Sep 7, 2019

new resource - azurerm_frontdoor [GH-3933]

8120e5e

ghost locked and limited conversation to collaborators Oct 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: Azure Front Door #3933

New Resource: Azure Front Door #3933

WodansSon commented Jul 26, 2019 •

edited

Loading

katbyte left a comment

katbyte Aug 21, 2019

WodansSon Aug 21, 2019

katbyte Aug 22, 2019

WodansSon Aug 22, 2019

katbyte left a comment

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte Aug 30, 2019

WodansSon Sep 4, 2019

katbyte Aug 30, 2019

WodansSon Sep 4, 2019

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte Aug 30, 2019

WodansSon Sep 5, 2019

katbyte left a comment

WodansSon commented Sep 7, 2019

ghost commented Sep 18, 2019

ghost commented Oct 7, 2019

	func FrontDoorName(i interface{}, k string) (_ []string, errors []error) {
	func ValidateFrontDoorName(i interface{}, k string) (_ []string, errors []error) {

	func BackendPoolRoutingRuleName(i interface{}, k string) (_ []string, errors []error) {
	func ValidateBackendPoolRoutingRuleName(i interface{}, k string) (_ []string, errors []error) {

	if v.EnabledState == frontdoor.Enabled {
	result["enabled"] = v.EnabledState == frontdoor.Enabled

New Resource: Azure Front Door #3933

New Resource: Azure Front Door #3933

Conversation

WodansSon commented Jul 26, 2019 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

WodansSon commented Sep 7, 2019

ghost commented Sep 18, 2019

ghost commented Oct 7, 2019

WodansSon commented Jul 26, 2019 •

edited

Loading