Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azurerm_cosmosdb_account: revert sdk name check workaround #4275

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

tracypholmes
Copy link
Contributor

Reverting fix #3747 for SDK bug #5157

@tracypholmes tracypholmes added this to the v1.34.0 milestone Sep 7, 2019
@tracypholmes tracypholmes requested a review from katbyte September 7, 2019 00:10
@ghost ghost added the size/XS label Sep 7, 2019
@katbyte katbyte self-assigned this Sep 7, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM providing the tests pass 👍

@katbyte
Copy link
Collaborator

katbyte commented Sep 8, 2019

Tests look good:
image

@katbyte katbyte merged commit 70a7a97 into master Sep 10, 2019
@katbyte katbyte deleted the revert-sdk-name-check-workaround branch September 10, 2019 09:29
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants